Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): determine whether a field is ambiguous with prefix #1135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(schema): determine whether a field is ambiguous with prefix #1135

wants to merge 1 commit into from

Conversation

j2gg0s
Copy link
Collaborator

@j2gg0s j2gg0s commented Feb 19, 2025

No description provided.

@j2gg0s
Copy link
Collaborator Author

j2gg0s commented Feb 19, 2025

I didn’t receive specific feedback, but based on the context, we should include the prefix when making the determination?

@vmihailenco

@j2gg0s j2gg0s requested a review from vmihailenco February 19, 2025 02:57
@vmihailenco
Copy link
Member

@j2gg0s you're probably right, but can we add a test to the table_test.go ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmihailenco vmihailenco Awaiting requested review from vmihailenco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j2gg0s @vmihailenco