perf: use buf in Args instead of bytebufferpool #1931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1856
Since
Args
already contains abuf
field, and multiple functions are designed to operate based on it, using thebuf
inArgs
results in a shorter process compared to usingbytebufferpool
. Additionally, based on the usage scenario, the number of calls toSetUint
is unlikely to exceed 10, or even 100. Under such circumstances, usingbuf
is significantly more efficient thanbytebufferpool
.Benchmark
Call
SetUint
multiple times with the same key to compare the performance of theAppendUint
step.Result
The results show that the implementation using
buf
is approximately 50% faster than usingbytebufferpool
.