sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 #313

malashin · 2018-02-06T13:41:14Z

No description provided.

houndci-bot · 2018-02-06T13:41:20Z

sdl/joystick.go

+	JOYSTICK_TYPE_GUITAR         = C.SDL_JOYSTICK_TYPE_GUITAR
+	JOYSTICK_TYPE_DRUM_KIT       = C.SDL_JOYSTICK_TYPE_DRUM_KIT
+	JOYSTICK_TYPE_ARCADE_PAD     = C.SDL_JOYSTICK_TYPE_ARCADE_PAD
+	JOYSTICK_TYPE_THROTTLE       = C.SDL_JOYSTICK_TYPE_THROTTLE


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:20Z

sdl/joystick.go

+	JOYSTICK_TYPE_DANCE_PAD      = C.SDL_JOYSTICK_TYPE_DANCE_PAD
+	JOYSTICK_TYPE_GUITAR         = C.SDL_JOYSTICK_TYPE_GUITAR
+	JOYSTICK_TYPE_DRUM_KIT       = C.SDL_JOYSTICK_TYPE_DRUM_KIT
+	JOYSTICK_TYPE_ARCADE_PAD     = C.SDL_JOYSTICK_TYPE_ARCADE_PAD


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:20Z

sdl/joystick.go

+	JOYSTICK_TYPE_FLIGHT_STICK   = C.SDL_JOYSTICK_TYPE_FLIGHT_STICK
+	JOYSTICK_TYPE_DANCE_PAD      = C.SDL_JOYSTICK_TYPE_DANCE_PAD
+	JOYSTICK_TYPE_GUITAR         = C.SDL_JOYSTICK_TYPE_GUITAR
+	JOYSTICK_TYPE_DRUM_KIT       = C.SDL_JOYSTICK_TYPE_DRUM_KIT


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:20Z

sdl/joystick.go

+	JOYSTICK_TYPE_ARCADE_STICK   = C.SDL_JOYSTICK_TYPE_ARCADE_STICK
+	JOYSTICK_TYPE_FLIGHT_STICK   = C.SDL_JOYSTICK_TYPE_FLIGHT_STICK
+	JOYSTICK_TYPE_DANCE_PAD      = C.SDL_JOYSTICK_TYPE_DANCE_PAD
+	JOYSTICK_TYPE_GUITAR         = C.SDL_JOYSTICK_TYPE_GUITAR


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

+	JOYSTICK_TYPE_WHEEL          = C.SDL_JOYSTICK_TYPE_WHEEL
+	JOYSTICK_TYPE_ARCADE_STICK   = C.SDL_JOYSTICK_TYPE_ARCADE_STICK
+	JOYSTICK_TYPE_FLIGHT_STICK   = C.SDL_JOYSTICK_TYPE_FLIGHT_STICK
+	JOYSTICK_TYPE_DANCE_PAD      = C.SDL_JOYSTICK_TYPE_DANCE_PAD


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

+	JOYSTICK_TYPE_GAMECONTROLLER = C.SDL_JOYSTICK_TYPE_GAMECONTROLLER
+	JOYSTICK_TYPE_WHEEL          = C.SDL_JOYSTICK_TYPE_WHEEL
+	JOYSTICK_TYPE_ARCADE_STICK   = C.SDL_JOYSTICK_TYPE_ARCADE_STICK
+	JOYSTICK_TYPE_FLIGHT_STICK   = C.SDL_JOYSTICK_TYPE_FLIGHT_STICK


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

+	JOYSTICK_TYPE_UNKNOWN        = C.SDL_JOYSTICK_TYPE_UNKNOWN
+	JOYSTICK_TYPE_GAMECONTROLLER = C.SDL_JOYSTICK_TYPE_GAMECONTROLLER
+	JOYSTICK_TYPE_WHEEL          = C.SDL_JOYSTICK_TYPE_WHEEL
+	JOYSTICK_TYPE_ARCADE_STICK   = C.SDL_JOYSTICK_TYPE_ARCADE_STICK


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

+const (
+	JOYSTICK_TYPE_UNKNOWN        = C.SDL_JOYSTICK_TYPE_UNKNOWN
+	JOYSTICK_TYPE_GAMECONTROLLER = C.SDL_JOYSTICK_TYPE_GAMECONTROLLER
+	JOYSTICK_TYPE_WHEEL          = C.SDL_JOYSTICK_TYPE_WHEEL


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

+// Types of a joystick.
+const (
+	JOYSTICK_TYPE_UNKNOWN        = C.SDL_JOYSTICK_TYPE_UNKNOWN
+	JOYSTICK_TYPE_GAMECONTROLLER = C.SDL_JOYSTICK_TYPE_GAMECONTROLLER


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-06T13:41:21Z

sdl/joystick.go

@@ -18,6 +113,20 @@ const (
 	HAT_LEFTDOWN  = C.SDL_HAT_LEFTDOWN
 )

+// Types of a joystick.
+const (
+	JOYSTICK_TYPE_UNKNOWN        = C.SDL_JOYSTICK_TYPE_UNKNOWN


don't use ALL_CAPS in Go names; use CamelCase

veeableful · 2018-02-07T02:30:02Z

@malashin, you can also take a look at my li/sdl2.0.6 branch and see if you can take parts of it into your branch. I was thinking of eventually splitting them to separate commits and merge them to master. But since you're also implementing SDL 2.0.6, perhaps it can save your time.

malashin · 2018-02-07T09:41:01Z

@veeableful, I renamed all getter methods from Joystick.GetVendor() to Joystick.Vendor(), But not sure about the other functions.

Should GameControllerGetAxisFromString() be GameControllerAxisFromString()?
What about GetCurrentVideoDriver()?

According to https://golang.org/doc/effective_go.html#Getters, they all should be renamed. We lose similarity to original C function names, but it is kinda lost already in many other places.

veeableful · 2018-02-07T09:59:44Z

@malashin Yeah definitely. You can rename them. I can't claim to know what's best for Go developers so go ahead!

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL
+	JOYSTICK_POWER_WIRED   = C.SDL_JOYSTICK_POWER_WIRED
+	JOYSTICK_POWER_MAX     = C.SDL_JOYSTICK_POWER_MAX


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL
+	JOYSTICK_POWER_WIRED   = C.SDL_JOYSTICK_POWER_WIRED


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+// (https://wiki.libsdl.org/SDL_JoystickPowerLevel)
+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:00Z

sdl/joystick.go

+// An enumeration of battery levels of a joystick.
+// (https://wiki.libsdl.org/SDL_JoystickPowerLevel)
+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL
+	JOYSTICK_POWER_WIRED   = C.SDL_JOYSTICK_POWER_WIRED
+	JOYSTICK_POWER_MAX     = C.SDL_JOYSTICK_POWER_MAX


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL
+	JOYSTICK_POWER_WIRED   = C.SDL_JOYSTICK_POWER_WIRED


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM
+	JOYSTICK_POWER_FULL    = C.SDL_JOYSTICK_POWER_FULL


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW
+	JOYSTICK_POWER_MEDIUM  = C.SDL_JOYSTICK_POWER_MEDIUM


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY
+	JOYSTICK_POWER_LOW     = C.SDL_JOYSTICK_POWER_LOW


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:01Z

sdl/joystick.go

+// (https://wiki.libsdl.org/SDL_JoystickPowerLevel)
+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN
+	JOYSTICK_POWER_EMPTY   = C.SDL_JOYSTICK_POWER_EMPTY


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2018-02-08T07:41:02Z

sdl/joystick.go

+// An enumeration of battery levels of a joystick.
+// (https://wiki.libsdl.org/SDL_JoystickPowerLevel)
+const (
+	JOYSTICK_POWER_UNKNOWN = C.SDL_JOYSTICK_POWER_UNKNOWN


don't use ALL_CAPS in Go names; use CamelCase

…0.4 (veandco#313)

malashin added 2 commits February 6, 2018 21:19

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6

59a99db

sdl: joystick: Fix documentation for GetAxisInitialState()

6670838

houndci-bot reviewed Feb 6, 2018

View reviewed changes

malashin added 2 commits February 7, 2018 19:17

sdl: gamecontroller, joystick: Fix stub, rename Getters

3a69be5

sdl: gamecontroller, joystick: Fix stub

83910e4

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.4

0a71657

houndci-bot reviewed Feb 8, 2018

View reviewed changes

malashin changed the title ~~sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6~~ sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 Feb 8, 2018

malashin merged commit 930022a into veandco:master Feb 10, 2018

neputevshina pushed a commit to neputevshina/go-sdl2 that referenced this pull request Nov 13, 2024

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.…

78437cb

…0.4 (veandco#313)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 #313

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 #313

malashin commented Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

houndci-bot Feb 6, 2018

veeableful commented Feb 7, 2018

malashin commented Feb 7, 2018

veeableful commented Feb 7, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

houndci-bot Feb 8, 2018

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 #313

sdl: gamecontroller, joystick: Add new bindings for SDL 2.0.6 and 2.0.4 #313

Conversation

malashin commented Feb 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

veeableful commented Feb 7, 2018

malashin commented Feb 7, 2018

veeableful commented Feb 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment