Respect `no-store` request header for `"use cache"` entries in dev mode #75754

unstubbable · 2025-02-06T15:46:23Z

In dev mode, when doing a hard refresh or using dev-tools with "disable cache" checked, the browser requests the page with a cache-control: no-store header. When this is the case, we ignore existing cache entries for "use cache" functions, and generate new ones instead. This is now the same behavior as for fetch caches.

closes NAR-58

ijjk · 2025-02-06T16:08:51Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
buildDuration	18.5s	18.5s	N/A
buildDurationCached	14.8s	12.4s	N/A
nodeModulesSize	393 MB	392 MB	N/A
nextStartRea..uration (ms)	420ms	429ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	537 B	N/A
withRouter.html gzip	519 B	520 B	N/A
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
middleware-b..fest.js gzip	677 B	672 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
app-page-exp...dev.js gzip	394 kB	393 kB	N/A
app-page-exp..prod.js gzip	132 kB	132 kB	N/A
app-page-tur..prod.js gzip	145 kB	145 kB	N/A
app-page-tur..prod.js gzip	141 kB	141 kB	N/A
app-page.run...dev.js gzip	382 kB	381 kB	N/A
app-page.run..prod.js gzip	128 kB	128 kB	N/A
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	N/A
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	N/A
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	N/A
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	N/A
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	N/A
Overall change	107 kB	107 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js hl/nar-58	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +2.53 kB
index.pack gzip	76 kB	75.7 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +2.53 kB

Diff details

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for bccd1874-HASH.js

@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
-  [7629],
+  [1758],
   {
-    /***/ 641: /***/ (
+    /***/ 8699: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
     ) => {
-      /* provided dependency */ var process = __webpack_require__(6611);
+      /* provided dependency */ var process = __webpack_require__(9829);
       /**
        * @license React
        * react-dom-client.production.js
@@ -22,9 +22,9 @@
  Modernizr 3.0.0pre (Custom Build) | MIT
 */
 
-      var Scheduler = __webpack_require__(8684),
-        React = __webpack_require__(1446),
-        ReactDOM = __webpack_require__(8307);
+      var Scheduler = __webpack_require__(462),
+        React = __webpack_require__(228),
+        ReactDOM = __webpack_require__(9221);
       function formatProdErrorMessage(code) {
         var url = "https://react.dev/errors/" + code;
         if (1 < arguments.length) {
@@ -14705,8 +14705,6 @@
       function getHoistableRoot(container) {
         return "function" === typeof container.getRootNode
           ? container.getRootNode()
-          : 9 === container.nodeType
-          ? container
           : container.ownerDocument;
       }
       var previousDispatcher = ReactDOMSharedInternals.d;
@@ -16253,14 +16251,14 @@
       };
       var isomorphicReactPackageVersion$jscomp$inline_1754 = React.version;
       if (
-        "19.1.0-canary-93b58361-20250209" !==
+        "19.1.0-canary-ff628334-20250205" !==
         isomorphicReactPackageVersion$jscomp$inline_1754
       )
         throw Error(
           formatProdErrorMessage(
             527,
             isomorphicReactPackageVersion$jscomp$inline_1754,
-            "19.1.0-canary-93b58361-20250209"
+            "19.1.0-canary-ff628334-20250205"
           )
         );
       ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16282,10 +16280,10 @@
       };
       var internals$jscomp$inline_2235 = {
         bundleType: 0,
-        version: "19.1.0-canary-93b58361-20250209",
+        version: "19.1.0-canary-ff628334-20250205",
         rendererPackageName: "react-dom",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.1.0-canary-93b58361-20250209",
+        reconcilerVersion: "19.1.0-canary-ff628334-20250205",
       };
       if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
         var hook$jscomp$inline_2236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16393,7 +16391,7 @@
         listenToAllSupportedEvents(container);
         return new ReactDOMHydrationRoot(initialChildren);
       };
-      exports.version = "19.1.0-canary-93b58361-20250209";
+      exports.version = "19.1.0-canary-ff628334-20250205";
 
       /***/
     },

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

failed to diff

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 1e02431

In dev mode, when doing a hard refresh or using dev-tools with "disable cache" checked, the browser requests the page with a `cache-control: no-store` header. When this is the case, we ignore existing cache entries for `"use cache"` functions, and generate new ones instead. This is now the same behavior as for `fetch` caches. closes NAR-58

ijjk · 2025-02-08T09:55:28Z

Tests Passed

gnoff · 2025-02-10T21:38:47Z

packages/next/src/server/app-render/work-async-storage.external.ts

@@ -73,6 +73,7 @@ export interface WorkStore {

  rootParams: Params
  dynamicIOEnabled: boolean
+  dev: boolean


We really should have a global constant that represents the dev runtime (as opposed to the NODE_ENV). this works for now I suppose but this is such a critical context useful in so many places tying it to an ALS that may not even be in scope is frustratingly limiting.

not that this should block landing this PR. but maybe you want to tackle that in aother effort if not now

gnoff · 2025-02-10T21:41:15Z

packages/next/src/server/use-cache/use-cache-wrapper.ts

+
+        const forceRevalidate =
+          workStore.dev &&
+          workUnitStore?.type === 'request' &&


I think this means that when we generate a fresh outer cache entry it is still possible for inner caches to be used. I think that's not quite equivalent to what we had before with unstable_cache and fetch cache (where there are no inner caches)

Probably we need to apply this forceRevalidate regardless of workUnitStore type

Fixed in 1e02431.

ijjk added created-by: Next.js team PRs by the Next.js team. tests type: next labels Feb 6, 2025

unstubbable marked this pull request as ready for review February 6, 2025 16:17

unstubbable requested a review from gnoff February 7, 2025 23:19

unstubbable force-pushed the hl/nar-58 branch from 21926dc to ea96b22 Compare February 8, 2025 09:42

gnoff reviewed Feb 10, 2025

View reviewed changes

Force-revalidate inner caches as well

1e02431

unstubbable requested a review from gnoff February 10, 2025 22:05

gnoff approved these changes Feb 10, 2025

View reviewed changes

unstubbable merged commit b0ae0b2 into canary Feb 10, 2025
130 checks passed

unstubbable deleted the hl/nar-58 branch February 10, 2025 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Respect `no-store` request header for `"use cache"` entries in dev mode #75754

Respect `no-store` request header for `"use cache"` entries in dev mode #75754

unstubbable commented Feb 6, 2025

ijjk commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 8, 2025 •

edited

Loading

gnoff Feb 10, 2025

gnoff Feb 10, 2025

gnoff Feb 10, 2025

unstubbable Feb 10, 2025

Respect no-store request header for "use cache" entries in dev mode #75754

Respect no-store request header for "use cache" entries in dev mode #75754

Conversation

unstubbable commented Feb 6, 2025

ijjk commented Feb 6, 2025 • edited Loading

Stats from current PR

ijjk commented Feb 8, 2025 • edited Loading

Tests Passed

gnoff Feb 10, 2025

Choose a reason for hiding this comment

gnoff Feb 10, 2025

Choose a reason for hiding this comment

gnoff Feb 10, 2025

Choose a reason for hiding this comment

unstubbable Feb 10, 2025

Choose a reason for hiding this comment

Respect `no-store` request header for `"use cache"` entries in dev mode #75754

Respect `no-store` request header for `"use cache"` entries in dev mode #75754

ijjk commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 8, 2025 •

edited

Loading