Skip to content

Add method to disable host verification for channels build with VertxChannelBuilder #38

Open
@dsimansk

Description

Hi,
I'd like to prose the following enhancement to VertxChannelBuilder.
When creating new channel the HttpClientOptions aren't exposed or editabled and takeover the defaults. I'd like to add either convenient method to disable hostname verification or expose HttpClientOptions object to pass the parameter.

It seems that since JDK 11 the hostname verification procedure has changed. Even for cases when trustAll(true) is used, the hostname verification is still applied and invalid hostnames e.g. localhost certificates may fail when accessed from outside. The same use case works fine on JDK 8 with dummy localhost certificates

Cc @spisiakm

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions