patched oracle script parsing

viant · Jul 15, 2019 · 830073f · 830073f
1 parent 9812ee2
commit 830073f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## July 10 2019 - v0.10.1
+    * Patched oracel script parseing
+
 ## July 10 2019 - v0.10.0
     * Added checkSchema
 

diff --git a/script/parser.go b/script/parser.go
@@ -128,7 +128,7 @@ outer:
 			pending += match.Matched
 		case plSQLBlock:
 			pending += string(match.Matched[:len(match.Matched)-1])
-			appendMatched("")
+			appendMatched(";")
 		case invalidToken:
 			break outer
 		case commandTerminator:

diff --git a/script/parser_test.go b/script/parser_test.go
@@ -26,7 +26,7 @@ SELECT 2;`,
 				`SELECT 1`,
 				`BEGIN
 SELECT 1;
-END`,
+END;`,
 				`SELECT 2`,
 			},
 		},
@@ -63,7 +63,7 @@ WHEN OTHERS THEN
 IF SQLCODE != -942 THEN
 RAISE;
 END IF;
-END`,
+END;`,
 				`INSERT INTO DUMMY(ID, NAME) VALUES(1, 'abc')`,
 				`CREATE OR REPLACE TRIGGER users_before_insert
 BEFORE INSERT ON users
@@ -72,7 +72,7 @@ BEGIN
 SELECT users_seq.NEXTVAL
 INTO   :new.id
 FROM   dual;
-END`,
+END;`,
 				`INSERT INTO DUMMY(ID, NAME) VALUES(2, 'xyz')`,
 			},
 		},