Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mysqlctl to docker images #7326

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add mysqlctl to docker images #7326

merged 1 commit into from
Jan 21, 2021

Conversation

askdba
Copy link
Contributor

@askdba askdba commented Jan 20, 2021 •
edited by deepthi
Loading

Signed-off-by: Alkin Tezuysal [email protected]

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

It was required to have mysqlctl as well as mysqlctld cc: @sougou

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@askdba
Add mysqlctl to docker images
05908c4 
Signed-off-by: Alkin Tezuysal <[email protected]>
@askdba askdba requested a review from sougou as a code owner January 20, 2021 14:12
@askdba askdba requested a review from deepthi January 20, 2021 14:12
deepthi
deepthi approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 73a698d into vitessio:master Jan 21, 2021
@deepthi deepthi deleted the mysqlctl_docker branch January 21, 2021 00:40
@deepthi
Copy link
Member

deepthi commented Jan 21, 2021

@sougou do we need to get this into 9.0?

@askdba askdba added this to the v9.0 milestone Jan 25, 2021
@eseokoh eseokoh mentioned this pull request May 31, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Build/CI
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@askdba @deepthi