Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the free Ubuntu ARM runners #1767

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Switch to the free Ubuntu ARM runners #1767

merged 2 commits into from
Jan 17, 2025

Conversation

esimkowitz
Copy link
Member

GitHub has made Ubuntu ARM runners free for OSS repos so we can retire our hosted runner.

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Walkthrough

The pull request involves a modification to the GitHub Actions workflow configuration file .github/workflows/build-helper.yml. Specifically, the change focuses on updating the runner specification for the Linux ARM platform. The runner designation has been simplified from ubuntu-24.04-arm64-16core to ubuntu-24.04-arm, removing the explicit core count specification. This adjustment may impact the execution environment for the ARM-based build job. The modification appears to be a minor adjustment to the runner configuration without altering the fundamental workflow structure or introducing changes to job steps, environment variables, or other workflow components.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 731eb27 and d7a84ce.

📒 Files selected for processing (1)
  • .github/workflows/build-helper.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/build-helper.yml

27-27: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
  • GitHub Check: merge-gatekeeper
  • GitHub Check: Build for TestDriver.ai
  • GitHub Check: build-app (windows, windows-latest)
  • GitHub Check: build-app (linux, ubuntu-24.04-arm)
  • GitHub Check: build-app (linux, ubuntu-latest)
  • GitHub Check: build-app (darwin, macos-latest)
🔇 Additional comments (1)
.github/workflows/build-helper.yml (1)

27-27: ⚠️ Potential issue

Invalid runner specification for GitHub-hosted ARM runner.

The runner label ubuntu-24.04-arm is not a valid GitHub-hosted runner specification. For GitHub-hosted ARM runners, you need to use a combination of the OS and architecture labels.

Apply this diff to fix the runner specification:

-                      runner: ubuntu-24.04-arm
+                      runner: ["ubuntu-latest", "arm64"]

Note: Since you're switching to GitHub-hosted runners, please verify that all build dependencies (especially the Linux-specific ones like libarchive-tools, libopenjp2-tools, etc.) are compatible with the ARM architecture.

Let's verify the availability of required packages on Ubuntu ARM:

✅ Verification successful

Invalid runner specification needs correction, but package compatibility is not a concern.

The runner specification needs to be corrected as mentioned in the original review, but I can confirm that the package dependencies will work correctly because:

  • All required packages are explicitly installed via apt-get
  • These are standard Ubuntu packages available across architectures
  • The installation is done after the runner starts, not relying on pre-installed packages

Apply this diff to fix the runner specification:

-                      runner: ubuntu-24.04-arm
+                      runner: ["ubuntu-latest", "arm64"]
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the required packages are available in the Ubuntu ARM repository
# Note: This uses the Ubuntu package API to check package availability

for pkg in libarchive-tools libopenjp2-tools rpm squashfs-tools; do
  echo "Checking $pkg..."
  curl -s "https://api.launchpad.net/1.0/ubuntu/focal/arm64/$pkg" | jq -r '.binary_package_version'
done

Length of output: 1146


Script:

#!/bin/bash
# Search for workflow files using these packages
echo "=== Searching for package usage in workflows ==="
rg -l "libarchive-tools|libopenjp2-tools|rpm|squashfs-tools" .github/workflows/

echo -e "\n=== Checking existing runner configurations ==="
rg -l "runs-on.*arm|runner.*arm" .github/workflows/

echo -e "\n=== Checking if these packages are installed in other workflows ==="
rg "(apt-get|apt) install.*(libarchive-tools|libopenjp2-tools|rpm|squashfs-tools)" .github/workflows/

Length of output: 832

🧰 Tools
🪛 actionlint (1.7.4)

27-27: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@esimkowitz esimkowitz merged commit 34bdd18 into main Jan 17, 2025
5 of 7 checks passed
@esimkowitz esimkowitz deleted the evan/free-arm-runner branch January 17, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant