print access log according to the attachment settings #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snail007
reviewed
Jul 26, 2022
| @@ -157,6 +158,9 @@ public class MotanConstants { | |||
| public static final String TRACE_CRECEIVE = "TRACE_CRECEIVE";// client端接收response | |||
| public static final String TRACE_CDECODE = "TRACE_CDECODE"; // client端解码response | |||
|
|
|||
| // ------------------ attachment constants ----------------- | |||
| public static final String ATT_PRINT_TRACE_LOG = "print_trace_log"; // 针对单请求是否打印（access）日志 | |||
There was a problem hiding this comment.
控制的是access log，使用trace字眼是否合适呢？
There was a problem hiding this comment.
trace log是一个纵向行为，trace log 标记可以控制整个链路中不同位置的log 行为，不只是针对access 日志，后续其他地方也可能会处理该标记，包括业务侧。
snail007
reviewed
Jul 26, 2022
| } | ||
|
|
||
| @Override | ||
| public Response filter(Caller<?> caller, Request request) { | ||
| if (accessLog == null) { | ||
| accessLog = caller.getUrl().getBooleanParameter(URLParamType.accessLog.getName(), URLParamType.accessLog.getBooleanValue()); | ||
| } | ||
| if (accessLog || MotanSwitcherUtil.isOpen(ACCESS_LOG_SWITCHER_NAME)) { | ||
| if (accessLog || needLog(request)) { |
There was a problem hiding this comment.
这里判断有点别扭，应该只一个方法needLog去判断，是否需要打印逻辑封装在needLog里面。
如果按着目前判断思路，if (accessLog || 特例情况1 || 特例情况2 || 特例情况2||...)，特例多起来不易于理解和维护。
There was a problem hiding this comment.
这里的想法是把access自身配置显示独立出来，其他都属于非配置情况下打印accesslog的场景，后续其他判断条件都会在needlog方法中进行判断。这里可以对needlog方法增加注释来进行补充说明
rayzhang0603
force-pushed
the
feat/print_trace_log
branch
from
584e8af to
b6ab469
Compare
rayzhang0603
force-pushed
the
feat/print_trace_log
branch
from
10cc239 to
c92a902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print access log according to the attachment settings