refactor(core): remove middleware from actions

[ematipico]

Changes

This PR a start to make Action more "core aware". In this PR the use of the middleware is completely removed, and its logic is moved inside the render-context.tsrender function, in particular the lastNext, which is the last function that is called during the rendering phase.

Testing

Current tests and functionality should stay the same. The Actions middleware was already set to be the last one, which is the same as we just moved inside the lastNext callback we have in core.

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 0cf031e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[florian-lefebvre]

Although this is a refactor, maybe should we have a changeset to be safe in case people face issues

[codspeed-hq]

CodSpeed Performance Report

Merging #13262 will not alter performance

_{Comparing refactor/astro-actions (0cf031e) with main (c5755e1)}

Summary

✅ 6 untouched benchmarks

[ematipico]

Turns out it is not as simple as that, it requires a full refactor of the architecture. I'll see to that

Outdated

[ematipico]

I checked the e2e test that failed, and the issue isn't much clear. The db package fails to run the seed file, however it doesn't happen when I run the dev server for the fixture.

Also, when running the fixture locally, the likes action (the action) works as expected, but the query doesn't return the expected data. This doesn't happen for the comments action.

As for now, I commented on them.