Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fonts): improve providers #13263

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Feb 18, 2025

Changes

  • Refactors fonts providers
  • To keep astro/config as lightweight as possible, splits providers in 2:
    • fonts/providers/index.ts only keeps the config part
    • in fonts/providers/entrypoints keep the implementation to be dynamically imported
  • Updates how a provider is dynamically imported to make it more easily testable

Testing

Added unit and types tests

Docs

N/A

@florian-lefebvre florian-lefebvre self-assigned this Feb 18, 2025
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: bb5ded9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 18, 2025
@florian-lefebvre florian-lefebvre changed the title feat: setup branch feat(fonts): improve providers Feb 18, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 18, 2025 14:50
@florian-lefebvre florian-lefebvre merged commit e8aead8 into feat/fonts Feb 18, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-improve-providers branch February 18, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants