Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fonts): better local provider #13276

Merged
merged 6 commits into from
Feb 21, 2025
Merged

feat(fonts): better local provider #13276

merged 6 commits into from
Feb 21, 2025

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Feb 20, 2025 •
edited
Loading

Changes

  • Simplifies code for url proxying and local font provider
  • Introduces a way to refresh local fonts in development
  • Local fonts hash is now computed based on the name and the file contents (RFC to be updated after this PR is merged)

Testing

Adds tests

Docs

N/A

@florian-lefebvre florian-lefebvre self-assigned this Feb 20, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c59d84b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 20, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 21, 2025 10:33
ematipico
ematipico reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some questions that I would like have answered before merging

@florian-lefebvre florian-lefebvre merged commit 8e89e80 into feat/fonts Feb 21, 2025
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-better-local-provider branch February 21, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-lefebvre @ematipico