Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of S/MIME Signing #298

Merged
merged 41 commits into from
Jan 2, 2025
Merged

Support of S/MIME Signing #298

merged 41 commits into from
Jan 2, 2025

Conversation

theexiile1305
Copy link
Contributor

This pull request resolve #296.

@theexiile1305 theexiile1305 marked this pull request as ready for review October 9, 2024 14:16
@theexiile1305
Copy link
Contributor Author

theexiile1305 commented Oct 9, 2024

@wneessen Now the PR is ready to be reviewed. Many thanks in advance.

Should I also add a notice in the README, so that S/MIME singing is now supported?

@theexiile1305
Copy link
Contributor Author

@wneessen The PR has now been improved again so that the README.md has been updated and an intermediate certificate can be added. These are also best practices for handling certificates.

I would like to take this opportunity to thank my contact at DFN-CERT for checking the handling of the certificates.

@wneessen
Copy link
Owner

wneessen commented Dec 7, 2024

As discussed we'll merge this as experimental with only "plain" mail support at this point. Multi-part support will follow later.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 61.37339% with 180 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (8646857) to head (1821cc7).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
pkcs7.go 52.99% 94 Missing and 16 partials ⚠️
msg.go 52.38% 29 Missing and 11 partials ⚠️
smime.go 75.00% 20 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   96.87%   91.29%   -5.59%     
==========================================
  Files          28       30       +2     
  Lines        3139     3595     +456     
==========================================
+ Hits         3041     3282     +241     
- Misses         68      251     +183     
- Partials       30       62      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen
Copy link
Owner

wneessen commented Jan 2, 2025

Even though some changes and tests are still needed (as discussed), I will now merge this completely instead of cherry-picking and then commit the changes in a seperate PR. Thanks again @theexiile1305 for all the efforts you put into this PR!

@wneessen wneessen merged commit 804fe25 into wneessen:main Jan 2, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of S/MIME Signing
2 participants