-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of S/MIME Signing #298
Conversation
…ssage should be singed with S/MIME when it's sent. Also, sMimeAuthConfig was introduced in client so that required privateKey and certificate can be used for S/MIME signing.
…cture, also adjusted tests
…r singing with S/MIME
@wneessen Now the PR is ready to be reviewed. Many thanks in advance. Should I also add a notice in the README, so that S/MIME singing is now supported? |
@wneessen The PR has now been improved again so that the I would like to take this opportunity to thank my contact at DFN-CERT for checking the handling of the certificates. |
…be nil. This behavior was changed with Go 1.23, according to https://go-review.googlesource.com/c/go/+/585856, also provieded tests
As discussed we'll merge this as experimental with only "plain" mail support at this point. Multi-part support will follow later. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 96.87% 91.29% -5.59%
==========================================
Files 28 30 +2
Lines 3139 3595 +456
==========================================
+ Hits 3041 3282 +241
- Misses 68 251 +183
- Partials 30 62 +32 ☔ View full report in Codecov by Sentry. |
Even though some changes and tests are still needed (as discussed), I will now merge this completely instead of cherry-picking and then commit the changes in a seperate PR. Thanks again @theexiile1305 for all the efforts you put into this PR! |
This pull request resolve #296.