Fix regression of custom smtp.Auth not working #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change re-introduces custom smtp.Auth support, which has been removed by accident. See #428. To make sure this does not happen again, a couple of tests have been added that make sure the custom auth is working as intended. This includes a `testCustomAuth` struct to verify the "CUSTOM" method and enhancements in the client to handle custom auth types. Resolves issue #428.
`t.Context()` was only just introduced in Go 1.24. Of course we cannot use that in general yet.
Upgraded the Go version in the .golangci.toml file from 1.23 to 1.24 to align with the latest Go release. This ensures compatibility and takes advantage of the newest features and improvements.
Removed redundant `nil` check for the subject header as `len(s) < 1` sufficiently ensures the desired logic. This is to make golangci-lint happy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 30 30
Lines 3536 3539 +3
=======================================
+ Hits 3349 3352 +3
Misses 138 138
Partials 49 49 ☔ View full report in Codecov by Sentry. |
james-d-elliott
approved these changes
Feb 16, 2025
wneessen
deleted the
bug/428_smtpauthcustom-setsmtpauth-doesnt-appear-to-be-effectual
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-introduces custom smtp.Auth support, which has been removed by accident. See #428. To make sure this does not happen again, a couple of tests have been added that make sure the custom auth is working as intended. This includes a
testCustomAuthstruct to verify the "CUSTOM" method and enhancements in the client to handle custom auth types. Resolves issue #428.