fix: tls config unused with dialer #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the configured tls.Config is used with the tls.Dialer.
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 83.03% 73.30% -9.73%
==========================================
Files 14 14
Lines 1444 1446 +2
==========================================
- Hits 1199 1060 -139
- Misses 170 340 +170
+ Partials 75 46 -29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for the PR James! Appreciated |
|
Codecov and sonarcube can be ignored. SQ seems to not work properly on PRs and codecov is confused about the different client_.go files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the configured tls.Config is used with the tls.Dialer.