Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add www package-lock.json and make it buildable #348

Merged
merged 1 commit into from
May 2, 2023
Merged

Add www package-lock.json and make it buildable #348

merged 1 commit into from
May 2, 2023

Conversation

tdaede
Copy link
Collaborator

@tdaede tdaede commented Apr 26, 2023

No description provided.

@tdaede tdaede requested a review from vibhoothi April 28, 2023 20:45
vibhoothi
vibhoothi approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, now we are able to build in docker space for frontend with IRC module.

Even tho I saw some compile time errors for some modules, and it turned out to be fine too [it could be unrelated to this patchset]

Thanks

@tdaede tdaede merged commit e972dcb into master May 2, 2023
@vibhoothi vibhoothi deleted the www_package_lock branch May 3, 2023 23:24
@vibhoothi vibhoothi mentioned this pull request May 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhoothi vibhoothi vibhoothi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdaede @vibhoothi