Read of uninitialized data

[kornelski]

rav1e/src/encoder.rs

Line 2246 in 21bb4cb

let mut ac: Aligned<[i16; 32 * 32]> = unsafe { Aligned::uninitialized() };

rav1e/src/encoder.rs

Line 2288 in 21bb4cb

&ac.data,

This uses the unsafe and theoretically UB Aligned::uninitialized() (#1572) and passes it first for reading to encode_tx_block, and only later writes to it in luma_ac.

Besides the unsafety, this looks like a logic bug.

[lu-zero]

ac is used only when in CFL mode so it is populated before it is used, we can make it a bit more apparent.

[lu-zero]

Thank you for spotting it :)