Add review policy.

[tdaede]

No description provided.

[coveralls]

Coverage remained the same at 71.127% when pulling 4ba93d2 on tdaede:reviews into cc7c5f3 on xiph:master.

[rzumer]

I am a bit uneasy about including URLs in commit messages, since they will probably eventually become inaccessible (and AWCY URLs can be quite long). Why are they needed specifically?

[YaLTeR]

Probably enough to have them in the PR

[tdaede]

It's so you can jump and look at more detailed results. I could make it optional I suppose.

[lu-zero]

Do we document how to run AWCY ?

[lu-zero]

Please mention that the patches should be rebased on top of the tree not merged.

[shssoichiro]

In addition to rebasing, should there be a comment about squashing commits? Do we enforce squashing commits?

[lu-zero]

We do not enforce squashing, sometimes makes sense if you push additional refinements as commits instead of reading and pushing an update.

…

On Mon, Aug 5, 2019, 17:30 Josh Holmer ***@***.***> wrote: In addition to rebasing, should there be a comment about squashing commits? Do we enforce squashing commits? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1529?email_source=notifications&email_token=AAB2LJBC27PUYUOPXVEN35LQDBBQPA5CNFSM4IJBPKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SF2PI#issuecomment-518282557>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB2LJC3MZTQSBWSPZRWCMDQDBBQPANCNFSM4IJBPKFA> .

[tdaede]

I originally enforced squashing, everyone hated it so I stopped. The main issue is that CI doesn't run on each individual commit, so by not squashing we have some revs that were never CI tested.

[YaLTeR]

On the one hand yes, but on the other hand I just had bisection pinpoint me to the exact small change leading to #1513 and that's super helpful to have.

[tdaede]

@lu-zero please re-review

The requested changes have been made.

[vibhoothi]

I think to match current documentation style, it will be good if it is in a separate file in doc/'s and link it the main readme for consistency,
(https://github.com/xiph/rav1e/blob/master/doc/README.md)

[barrbrain]

To clarify, the Contributing chapter has moved to CONTRIBUTING.md. This section should be added to that document.

[barrbrain]

This might need to be manually reapplied to the new file but it would be great to finally merge this.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e6cd02) 88.24% compared to head (922496c) 88.24%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files          88       88           
  Lines       28210    28210           
=======================================
  Hits        24893    24893           
  Misses       3317     3317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.