Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace rayon with WIP latch-target-thread branch. #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdaede
Copy link
Collaborator

@tdaede tdaede commented Nov 5, 2019

No description provided.

@jamrial
Copy link
Contributor

jamrial commented Nov 5, 2019

Wouldn't it be safer to include a known good snapshot of this branch inside the crates folder, and use that instead of a remote private branch that may change in unpredictable ways?

Also, https://doc.rust-lang.org/edition-guide/rust-2018/cargo-and-crates-io/replacing-dependencies-with-patch.html mentions that [patch] should be used instead of [replace].

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 75.614% when pulling f27967f on tdaede:rayon_replace into 9e1c711 on xiph:master.

@tdaede
Copy link
Collaborator Author

tdaede commented Nov 5, 2019

Yes, sorry I forgot to mark this WIP. I'd rather figure out why this is the case (the rayon branch is not supposed to improve performance, just reduce cpu utilization of idle threads) and then get a full release of rayon.

@tdaede tdaede changed the title Replace rayon with WIP latch-target-thread branch. [WIP] Replace rayon with WIP latch-target-thread branch. Nov 5, 2019
@lu-zero lu-zero added the WorkInProgress Incomplete patchset label Nov 5, 2019
@lu-zero
Copy link
Collaborator

lu-zero commented Nov 20, 2019

With this patch on top of 7344dae, Bosphorus 4k 8bit.

4x4 tiles on a 8 threads i7:

encoded 600 frames, 0.292 fps, 5481.45 Kb/s

7344dae alone:

encoded 69 frames, 0.279 fps, 6129.46 Kb/s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WorkInProgress Incomplete patchset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants