Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Do both downsamples in the same loop. #2053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Do both downsamples in the same loop. #2053

wants to merge 1 commit into from

Conversation

tdaede
Copy link
Collaborator

@tdaede tdaede commented Jan 10, 2020

No description provided.

KyleSiefring
KyleSiefring reviewed Jan 10, 2020
View reviewed changes
src/frame/plane.rs
}
}
hres.pad(frame_width, frame_height);
hres.pad(frame_width, frame_height);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qres

lu-zero
lu-zero reviewed Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside the pad() it looks fine, potentially you could iterate over 2 rows of the source while mutating 1 row for each downsampled plane, but it may be explored later.

@barrbrain barrbrain added the WorkInProgress Incomplete patchset label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero left review comments

@KyleSiefring KyleSiefring KyleSiefring left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WorkInProgress Incomplete patchset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdaede @lu-zero @KyleSiefring @barrbrain