[WIP] Don't require writing coeffs for txfm reconstruction #2086
Conversation
|
I think this is only triggered when tx_domain_rate is true. It never is. If I turn it on, I get a segfault with my patch. Looking at the commit that added this if statement, I feel that I should remove the branch. Going to have to ask Thomas. |
|
|
||
| let has_coeff = if need_recon_pixel || rdo_type.needs_coeff_rate() { | ||
| if rdo_type.needs_coeff_rate() { |
There was a problem hiding this comment.
I think you have missed the condition "need_recon_pixel ||" here? That become true, for ex, when there are multiple tx blocks in a partition and the prediction mode of the partition is intra prediction. Since ref pixels for there should be pixel domain.
| @@ -3987,7 +3987,7 @@ impl<'a> ContextWriter<'a> { | |||
|
|
|||
| if eob == 0 { | |||
| self.bc.set_coeff_context(plane, bo, tx_size, xdec, ydec, 0); | |||
| return false; | |||
There was a problem hiding this comment.
With this change you aren't setting the coefficient context anymore. This might be OK, if you verify that the initial value of the coefficient context in bc is correct, and it's always restored to that after an RDO rollback.
No description provided.