Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fine directional intra prediction between speed levels 2 and 5 #2171

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Disable fine directional intra prediction between speed levels 2 and 5 #2171

merged 1 commit into from
Feb 15, 2020

Conversation

takehirokj
Copy link
Collaborator

Closes #2167.

~30% speed up in speed 5 in AWCY.

PSNR PSNR Cb PSNR Cr PSNR HVS SSIM MS SSIM CIEDE 2000
0.6833 1.4316 1.3890 0.6723 0.7174 0.6667 0.8463

@takehirokj takehirokj requested a review from rzumer February 14, 2020 15:09
rzumer
rzumer reviewed Feb 14, 2020
View reviewed changes
@rzumer rzumer mentioned this pull request Feb 14, 2020
Merged
@takehirokj takehirokj force-pushed the disable_fine_dir_pred_at_some_speed branch from 38cd75b to 4af5f33 Compare February 14, 2020 23:27
@takehirokj takehirokj changed the title Enable fine directional intra prediction only in speed 0 and 1 Disable fine directional intra prediction between speed levels 2 and 5 Feb 14, 2020
@rzumer rzumer merged commit 7d60a68 into xiph:master Feb 15, 2020
@takehirokj takehirokj deleted the disable_fine_dir_pred_at_some_speed branch February 15, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzumer rzumer rzumer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fine directional prediction seems slower than it's worth at some speed levels
2 participants
@takehirokj @rzumer