Channel API #2451
Merged
Channel API #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
force-pushed
the
channel-api
branch
3 times, most recently
from
6f3abec to
dbe4217
Compare
lu-zero
force-pushed
the
channel-api
branch
3 times, most recently
from
54975b0 to
98fd0ea
Compare
shssoichiro
reviewed
Jul 30, 2020
Urhengulas
suggested changes
Aug 6, 2020
| if self.limit < self.count { | ||
| Err(TrySendError::Full(data)) | ||
| } else { | ||
| let r = self.sender.try_send(data); |
There was a problem hiding this comment.
it makes the code more verbose.
There was a problem hiding this comment.
I actually think it makes it easier to read. But maybe just a preference.
src/bin/rav1e-ch.rs
Outdated
| }); | ||
|
|
||
| // Receive Packets | ||
| let d = s.spawn(move |_| -> Result<(), CliError> { |
There was a problem hiding this comment.
Maybe not use d as variable name?
|
|
||
| info!( | ||
| "Using y4m decoder: {}x{}p @ {}/{} fps, {}, {}-bit", | ||
| video_info.width, |
There was a problem hiding this comment.
Maybe also move these attributes out to make it less verbose?
let width = video_info.width;
// ...
lu-zero
force-pushed
the
channel-api
branch
3 times, most recently
from
d37ffcf to
73225b7
Compare
vibhoothi
reviewed
Aug 28, 2020
The internal version will be used by the channel API.
It will be used by the Channel API.
vibhoothi
reviewed
Aug 31, 2020
shssoichiro
approved these changes
Aug 31, 2020
|
Now with the commits collapsed without the interims :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set provides a channel-based API that should make much simpler the normal usage.
TODO:
Open questions:
last-errorinside the ReceiverPacket abstraction and a mean to retrieve itSolves: #689
(apparently github got some consistency issue with #2118 so I ended up opening this)