-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cli option to use the high_bitdepth codepath for 8bit content #2746
Conversation
I was able to find desyncs by adapting the fuzzer to run 8-in-16. Here is one small such config: DecodeTestParameters {
w: 16,
h: 31,
speed: 6,
q: 0,
limit: 2,
bit_depth: 8,
chroma_sampling: Cs420,
min_keyint: 1,
max_keyint: 4,
switch_frame_interval: 0,
low_latency: false,
error_resilient: false,
bitrate: 11523,
tile_cols_log2: 1,
tile_rows_log2: 0,
still_picture: false,
} I collected 535 failure examples by enabling 8-in-16 in the encode_decode fuzzer: For reference, this was the complete corpus I filtered for the above crashes: |
Shall we refresh it and try it again ? |
Let's refresh this and see how much breaks in the process :) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2746 +/- ##
==========================================
+ Coverage 88.24% 88.49% +0.25%
==========================================
Files 88 88
Lines 28210 28212 +2
==========================================
+ Hits 24893 24967 +74
+ Misses 3317 3245 -72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would somewhat prefer it be a hidden flag or have a "Here there be dragons" warning attached. We can fuzz and run through AWCY to verify.
Useful mainly for debugging purposes
Rebased and now with the cli tests wired in. |
No description provided.