Remove duplicate assume_slice_init_mut #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
force-pushed
the
remove-duplicate-maybeuninit-helper
branch
from
ea7c736 to
ba55ff0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3322 +/- ##
==========================================
- Coverage 88.48% 88.48% -0.01%
==========================================
Files 88 88
Lines 28235 28230 -5
==========================================
- Hits 24985 24980 -5
Misses 3250 3250 ☔ View full report in Codecov by Sentry. |
|
Sad that the std version is nightly only. |
shssoichiro
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two functions are equivalent except for an additional
T: Copybound on one function. That bound is always fulfilled at the moment, so I left it as-is.I preferred the name
slice_assume_init_mutover the other one because std uses the same name.