Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-specific clippy lints #3323

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

shssoichiro
Copy link
Collaborator

These aren't checked for in CI, but it's not a bad idea to fix them anyway.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8a2f25d) 88.52% compared to head (c5409f6) 88.53%.

Files Patch % Lines
src/partition.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3323   +/-   ##
=======================================
  Coverage   88.52%   88.53%           
=======================================
  Files          89       89           
  Lines       28334    28330    -4     
=======================================
- Hits        25084    25082    -2     
+ Misses       3250     3248    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shssoichiro shssoichiro force-pushed the clippy-test-fixes branch 3 times, most recently from 75811c2 to 5ba25c7 Compare January 6, 2024 21:31
Copy link
Collaborator

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Full clippy checks could be set up but I think that is non-trivial.

@shssoichiro shssoichiro merged commit 585b244 into xiph:master Jan 12, 2024
@shssoichiro shssoichiro deleted the clippy-test-fixes branch January 12, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants