Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crate quickcheck_macros #3328

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

FreezyLemon
Copy link
Contributor

This is the last dependency that requires version 1 of syn (see #3254):

$ cargo tree | grep -c "syn v1"
0

quickcheck_macros isn't actually required, and quickcheck is already on version 2 of syn. The code change that is needed to remove quickcheck_macros is very small, so I don't see a reason not to do it.

@FreezyLemon FreezyLemon force-pushed the remove-quickcheck-macros branch from 9b2ea22 to e9ee438 Compare January 1, 2024 20:34
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15f47f5) 88.48% compared to head (e9ee438) 88.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3328   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          88       88           
  Lines       28230    28231    +1     
=======================================
+ Hits        24980    24981    +1     
  Misses       3250     3250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@shssoichiro shssoichiro merged commit 97cb667 into xiph:master Jan 1, 2024
@FreezyLemon FreezyLemon deleted the remove-quickcheck-macros branch January 1, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants