Fix NASM warning about %undef statement #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3329 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 89 89
Lines 28330 28330
=======================================
Hits 25082 25082
Misses 3248 3248 ☔ View full report in Codecov by Sentry. |
FreezyLemon
force-pushed
the
fix-nasm-warnings
branch
from
ea4ce7c to
1cd7a5f
Compare
barrbrain
approved these changes
Jan 12, 2024
NASM warns that everything after the first argument is ignored, so each %undef needs its own line. There seems to be no res macro, so I removed the %undef for it.
barrbrain
force-pushed
the
fix-nasm-warnings
branch
from
1cd7a5f to
c3a3db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My local version of NASM (2.16.01) produces some warnings when compiling:
Looks like the
%undef sum, kernel_width, resonly undefinessumand ignores everything after that.resdoesn't seem to exist (anymore), so I removed it from the%undefs.