Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace to compiler flags in long version string #3346

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

FreezyLemon
Copy link
Contributor

From the reference regarding environment variables set by Cargo:

CARGO_ENCODED_RUSTFLAGS — extra flags that Cargo invokes rustc with, separated by a 0x1f character (ASCII Unit Separator).

Before:

Compiler Flags: -Ctarget-cpu=native-Clink-arg=-fuse-ld=mold

After:

Compiler Flags: -C target-cpu=native -C link-arg=-fuse-ld=mold

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6f4969) 88.53% compared to head (94e0623) 88.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3346   +/-   ##
=======================================
  Coverage   88.53%   88.54%           
=======================================
  Files          89       89           
  Lines       28330    28334    +4     
=======================================
+ Hits        25082    25087    +5     
+ Misses       3248     3247    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shssoichiro
Copy link
Collaborator

Interesting. tbh I didn't realize the previous version didn't even have a space between the different flags.

@shssoichiro shssoichiro merged commit 7155fe3 into xiph:master Jan 28, 2024
25 checks passed
@FreezyLemon FreezyLemon deleted the readable-rustflags-in-version branch January 28, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants