Turn get_rect_tx_log_ratio into associated function for TxSize #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
force-pushed
the
refactor-txsize-rect-ratio
branch
from
54567e8 to
4398cb8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3353 +/- ##
==========================================
+ Coverage 88.52% 88.72% +0.20%
==========================================
Files 89 89
Lines 28323 27754 -569
==========================================
- Hits 25074 24626 -448
+ Misses 3249 3128 -121 ☔ View full report in Codecov by Sentry. |
FreezyLemon
force-pushed
the
refactor-txsize-rect-ratio
branch
from
4398cb8 to
02f3d37
Compare
FreezyLemon
force-pushed
the
refactor-txsize-rect-ratio
branch
from
02f3d37 to
b6f5b54
Compare
FreezyLemon
changed the title
tmatth
approved these changes
Aug 14, 2024
lu-zero
force-pushed
the
refactor-txsize-rect-ratio
branch
from
b6f5b54 to
13ee0da
Compare
shssoichiro
force-pushed
the
refactor-txsize-rect-ratio
branch
from
13ee0da to
f1c90e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_rect_tx_log_ratiois only used with width & height ofTxSize(tx is in the name), so it makes sense to make it aTxSizemethod instead.Using
tx_size.width_log2() - 2seemed more straightforward than the call toILog, so I replaced that too.