Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop for very short clips with frame reordering #919

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix infinite loop for very short clips with frame reordering #919

merged 1 commit into from
Feb 5, 2019

Conversation

shssoichiro
Copy link
Collaborator

Fixes #890. Also fixes the tests to test frame reordering and lookahead correctly.

@shssoichiro shssoichiro requested review from lu-zero and tdaede February 4, 2019 20:24
@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 81.985% when pulling 6db88ad on shssoichiro:890-reorder-loop into 27427d0 on xiph:master.

lu-zero
lu-zero reviewed Feb 4, 2019
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here some initial comments and thank you for finding a solution.

Tomorrow I'd merge it after a second read.

@lu-zero lu-zero merged commit ccd6faa into xiph:master Feb 5, 2019
@shssoichiro shssoichiro deleted the 890-reorder-loop branch February 5, 2019 14:27
shssoichiro added a commit to shssoichiro/rav1e that referenced this pull request Feb 5, 2019
@shssoichiro
Fix failing build
e5ab24e 
PRs xiph#912, xiph#919, and xiph#922 contained changes which conflicted with one
another, and needed to be reconciled in order to get the build to pass
with all of these changes together
@shssoichiro shssoichiro mentioned this pull request Feb 5, 2019
Merged
shssoichiro added a commit that referenced this pull request Feb 5, 2019
@shssoichiro
Fix failing build (#928)
991bf1d 
PRs #912, #919, and #922 contained changes which conflicted with one
another, and needed to be reconciled in order to get the build to pass
with all of these changes together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

@tdaede tdaede Awaiting requested review from tdaede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never Ending task with a very low frame count .y4m file
3 participants
@shssoichiro @coveralls @lu-zero