Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the outdated extern crate macro for importing dependencies #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthiasbeyer
Copy link

PR Details

Tackles #72

I am not a Go person and I didn't look into anything else than just where the extern_crate macro is used and replaced it.

This may not work at all. But it is a proposal.

Description

Related Issue

#72

Motivation and Context

Generated outdated Rust is an issue because the output does not compile right after being generated, so the code needs manual or automated cleanup, which is tedious.

How Has This Been Tested

Not at all.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Not sure.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant