Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests verify url #9

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Tests verify url #9

merged 4 commits into from
Apr 14, 2022

Conversation

hionay
Copy link
Contributor

@hionay hionay commented Apr 14, 2022

  • added a CA certificate for testing (I had to remove *.pem line from .gitignore)
  • added tests for verifying URL

closes #8

@codecov-commenter
Copy link

Codecov Report

Merging #9 (494121e) into main (cbc0b89) will increase coverage by 3.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   80.00%   83.30%   +3.30%     
==========================================
  Files           7        7              
  Lines         635      635              
==========================================
+ Hits          508      529      +21     
+ Misses         99       79      -20     
+ Partials       28       27       -1     
Impacted Files Coverage Δ
commands/verify/verify.go 92.30% <100.00%> (+16.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc0b89...494121e. Read the comment docs.

@yakuter
Copy link
Owner

yakuter commented Apr 14, 2022

This is great :) Thank you @hionay 👍

@yakuter yakuter merged commit 4dad7b9 into yakuter:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verifying url with CA
3 participants