Update file extensions for Node TS support #6596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything stopping progress on this PR? |
RDIL
changed the title
.mts as an es module file
|
Sorry @adrian-gierakowski, completely forgot to follow up here. |
merceyz
requested changes
Jan 20, 2025
goloveychuk
suggested changes
Jan 27, 2025
| @@ -20,3 +20,6 @@ export const SUPPORTS_IMPORT_ATTRIBUTES = major >= 21 || (major === 20 && minor | |||
|
|
|||
| // https://github.com/nodejs/node/pull/52104 | |||
| export const SUPPORTS_IMPORT_ATTRIBUTES_ONLY = major >= 22; | |||
|
|
|||
| // https://github.com/nodejs/node/pull/53725 | |||
| export const SUPPORTS_TYPE_STRIPPING = major > 23 || (major === 23 && minor > 6); | |||
There was a problem hiding this comment.
to make strip types works, you need to change pnp mjs loader and chain other loaders , because (assumption is) types stripes is implemented as loader also.
#6595 (comment)
There was a problem hiding this comment.
test with simple type cast ( as any) could written to validates this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #6595
How did you fix it?
Always consider
mtsas ESM andctsas CJSChecklist