Fix for #58 - Adding support for loading startup files #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunabe
reviewed
May 24, 2018
| "syscall" | ||
|
|
||
| "github.com/golang/glog" | ||
| zmq "github.com/pebbe/zmq4" | ||
| ) | ||
|
|
||
| const jupyterStartupDirectoryPath = ".jupyter/startup/" |
There was a problem hiding this comment.
How did you decide this path?
Do you have any reference?
I tried to find an official document about the start-up scripts in Jupyter notebook. But I can not find it. Instead, I found some documents mention .ipython/profile_default/startup.
There was a problem hiding this comment.
I had read somewhere that the ~/.ipython/profile_default/startup is getting deprecated in favour of ~/.jupyter/startup. However, I'm not able to find the link. Let me check.
| @@ -137,6 +146,46 @@ func NewServer(connectionFile string, handlers RequestHandlers) (server *Server, | |||
| }, nil | |||
| } | |||
|
|
|||
| func loadStartupScripts(execQueue *executeQueue, shell *shellSocket) { | |||
There was a problem hiding this comment.
I want to keep gojupyterscaffold package as a layer to implement Jupyter protocol (http://jupyter-client.readthedocs.io/en/stable/messaging.html) and independent from Go.
Please move your code to cmd/lgo-internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading startup files from ~/.jupyter/startup folder in sorted order. Any go file present in the folder will be loaded. Files should not have a package statement at the beginning of the file though.