Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_finder match ">" redirect to command_palette #8704

Closed
wants to merge 1 commit into from

Conversation

d1y
Copy link
Contributor

@d1y d1y commented Mar 2, 2024

#8703

Before:

After:

after

Release Notes:

  • Improved file_finder

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 2, 2024
@maxdeviant
Copy link
Member

This seems like a specific VS Code-ism that I don't think really fits in Zed the way these two palettes work right now.

In VS Code it seems that they're both a single palette, and presence of the > allows mode-switching within it.

Having > in the file picker close the file picker and open the command palette (with no way to return) feels weird.

It's also pretty seamless to alternate between the file picker and the command palette using the hotkeys right now. Here's me alternating between Cmd + P and Cmd + Shift + P:

Screen.Recording.2024-03-02.at.10.52.48.AM.mov

I'm going to close this out until we feel there's a clear need to add something like this.

@maxdeviant maxdeviant closed this Mar 2, 2024
@Moshyfawn
Copy link
Member

@maxdeviant, do you think this is something the team would consider if there were enough votes for the original request, or should we close it?

@maxdeviant
Copy link
Member

@maxdeviant, do you think this is something the team would consider if there were enough votes for the original request, or should we close it?

I think we can leave it open for now to at least gauge the interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants