Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all node modules where possible #1052

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Conversation

area
Copy link
Member

@area area commented Jun 17, 2022

The output of npm outdated is now

Package                     Current           Wanted  Latest  Location                            Depended by
openzeppelin-solidity         3.4.2            3.4.2   4.6.0  node_modules/openzeppelin-solidity  colonyNetwork
solidity-coverage      0.8.0-beta.1  0.8.0-rc.test.0  0.7.21  node_modules/solidity-coverage      colonyNetwork

solidity-coverage is a false positive, and openzeppelin-solidity v4 needs solidity v8, so will be done in the solidity branch.

Draft until I've investigated some other stuff, but still interested in feedback. In particular, I've removed request and request-promise (I think) which are deprecated

@area area force-pushed the maint/major-upgrades branch from cf302ab to ce2eedc Compare June 21, 2022 08:14
@area area marked this pull request as ready for review June 22, 2022 08:53
@kronosapiens kronosapiens merged commit 2aa2901 into develop Jun 22, 2022
@kronosapiens kronosapiens deleted the maint/major-upgrades branch June 22, 2022 17:47
@area area mentioned this pull request Jun 24, 2022
@area area mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants