-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to npm #1055
Merged
Merged
Switch to npm #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae90c7
to
63b383f
Compare
121486b
to
6ad1238
Compare
cf302ab
to
ce2eedc
Compare
fd80b2d
to
ef1b57b
Compare
ef1b57b
to
e3969a3
Compare
Can we please be kept in the look as when this makes it's way into |
5cca839
to
1c88401
Compare
1c6fe8b
to
3f4eea8
Compare
It works! All the tests are passing and I also tested the reputation miner locally. |
This is necessary for npm and the linter to pick it up properly
bda68c7
to
f540696
Compare
e9660e5
to
542bb94
Compare
542bb94
to
ca926b1
Compare
Rebased and working again! I applied |
kronosapiens
approved these changes
Sep 9, 2022
@rdig heads up this has been merged to develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn
was great at a time when npm was lacking the speed, the consistency and the features it provided. These days are over now as npm has caught up. I propose to switch this project (back?) to npm and with that improve compatibility (node version usually determines npm version) and remove dependencies while at the same time create consistency with all other Colony projects.I used https://github.com/imsnif/synp to convert the
yarn.lock
to apackage-lock.json
. The process is like so:yarn.lock
fileyarn --frozen-lockfile
package-lock.json
npx synp --source-file yarn.lock --with-workspace
npm install
package-lock.json
We also move from Meta to Microsoft 😬
Changes for the run-scripts:
.bin
folder, in thepackage.json
one does not need to useyarn
oryarn run
, so I removed thoseyarn EXECUTABLE
in other places was replaced withnpx EXECUTABLE
(the npm canonical way to execute the.bin
executables)yarn (run) SCRIPT
in thepackage.json
was replaced withnpm run SCRIPT
It seems to be going through fine. We still have to test/adjust the following:
Note: as this PR is based on top of #1052 I suggest to merge that PR first and have the CircleCI checks run on this one
This PR closes #1050.