Add code quality checking tools / linters to Travis

[orenyk]

As suggested by @mnquintana, to prepare the app for more open contributions (and to clean up some of our mess), we should add code quality tools like rubocop and other linters to Travis to make sure we're writing good code. It will also give us ideas for refactoring / improvement.

I think as part of that we're gonna have to implement some code quality tools and make sure we run them on travis to enforce code style and stuff (ie. rubocop, jscs, jshint, any other linters I can't think of)

[orenyk]

Tried running rubocop, it found over 4400 problems :-(

While googling around I found this solution for multiline Ruby strings, we should implement the first option for all of those extra long lines we have floating around.

[mnquintana]

Hahaha jscs found over 1200 problems, so many that Travis basically gave up on trying to render the whole log in-browser.

jshint is still going.

There are so many code issues with the JS alone that it's added like 6 mins onto our build time.

[mnquintana]

Alright, at least for the JS linters the best way to go (to make them usable both locally and on Travis) was to limit the max number of errors displayed to 50 for each. Unfortunately, it doesn't look like rubocop has that option. 😕

[orenyk]

It's ok, I'm going to try to fix most of the "lines are too long" errors before we merge this back in. It still might not be enough, but we'll see how it goes.

[orenyk]

I'm tweaking the rubocop settings to be more permissive to account for our current code state (e.g. increasing the max method line length, etc) and we've merged in the JS linters. I'd like to merge all of the open PR's into master and merge that into here before making any changes to the code itself (to avoid conflicts), but once that's done we can put these to use.

In terms of the JS linters, since they won't be passing unless we fix our JS code, do we want to maybe comment them out of the build to avoid failing builds for now? Otherwise I think the GitHub - Travis integration will be a little useless. Thoughts?

[mnquintana]

We could definitely comment them out for now (the JS linters) – we'll just have to remember to uncomment them once we're ready again. :)

[orenyk]

Sounds good, I'll add a comment to #1061 as we can bundle in a general refactoring of the JS code in there as well.

[orenyk]

Ok, I didn't follow my own advice and have been cleaning up files all day :-). I've gone through the controllers, decorators, and helpers and have been ignoring rubocop where I felt that properly refactoring would take too much work. I also removed two files left over from the log purge (a helper and associated specs). 676 (out of 976) offenses to go!