#1075 Travis Linters #1078
#1075 Travis Linters #1078
Conversation
test for npm existence check node version and install linters run jscs and jshint fix jscs and jshint globbing issue change order of script tasks add imagemagick version check print ghostscript version add jshint and jscs config for consistent linting reduce max errors printed ignore vendor dir skip production, staging, and development gems
[1075] Add jscs and jshint
|
Looks good to me! Is this ready to merge then? |
|
I'm actually going to remove |
|
Ok, that's done. I want to go over the changes myself one more time but if it all looks good to you I'll merge it in afterwards. |
|
Is that the same spec that usually fails for no apparent reason? https://travis-ci.org/YaleSTC/reservations/builds/45691443#L327 |
|
Yup, I'm going to try and debug it once I've finished with this. If I can't figure it out quickly then I'll just comment it out :-\ . |
| @@ -11,13 +11,32 @@ env: | |||
| secure: IHUYMK2spxorl9lUeAbAfT6btuP2qRT615bUnEuUDgYrXf9y1CdQprYWJaygou/+6aWmLL0NnxYSpOxi40bHgMKeUQnTjXVbkkqQ1Tml3cMSsjkBrx7CNUygHvDDzCQCEC6m9uZjUKMZAVzVSWlOQhSMKR7MtdsSvMCrKIgA2pM= | |||
|
|
|||
| before_install: | |||
| # these are all for JS linters, uncomment when they are to be used | |||
| # - convert -version | |||
| # - gs -v | |||
There was a problem hiding this comment.
Could you uncomment this and the previous line? Those aren't for the JS linters – they're printing the versions of two of our system dependencies, ImageMagick and GhostScript, to be able to see what Travis is running.
|
Alright everything looks good (just the one change in my code comment) |
|
agreed with machiste, i merged master in and dealt with the merge conflicts so this is good to go when those lines are uncommented and you're ready |
|
I think we should merge this before any other PRs so Travis can check them for rubocop conformance. |
|
yea, i think so too. if those commented lines are all that really needs to be done I can go ahead and do that (and pull in) if necessary |
|
I'll uncomment those lines and merge this in, thanks guys! |
|
freaking rake test, merging. |
Resolves #1075, rake task spec still failing most of the time.