Extra 1px on bottom of navbar

[mnquintana]

This issue has been around pretty much since my 2012 redesign, but it's been driving me crazy since then. The navbar is exactly 1px taller than it should be, and I have never been able to figure out why (hence diff: 5 lol). I doubt I'll be resolving this as part of #245 – someone should take a look at this if they get bored.

[orenyk]

Uch CSS madness like this is the worst.

[mnquintana]

OMG I FOUND IT! This will in fact be fixed by #245 after all!

This was actually not our fault – if you inspect the fixed-to-top navbar component in Bootstrap's docs, you'll see that it's also 1px too tall (51px instead of 50px). It's because of this property:

.navbar-fixed-top {
  border-width: 0 0 1px;
}

Which is making the bottom border add a width of 1px, hence the 51px navbar. Just had to set it to 0. It's the simple things. 😄