Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Markdown in flashes removing HTML links #1124

Closed
@orenyk

Description

@orenyk

Since we started Markdown-rendering our flashes (#1027, my bad) we've been removing all HTML in our flash messages since our Markdown renderer was configured to do so. As a result, the persistent view mode flash no longer has functioning links.

This can be easily solved by a) not removing HTML during Markdown rendering or b) optionally not removing HTML during Markdown rendering by passing a second parameter to the markdown method (in ApplicationHelper and in _flash_alerts.html.erb`). I vote for the latter, this should be a quick fix and we can stick it in v5.2.0.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions