Banned user validations

[orenyk]

User feedback (running v3.4.8):

Banned users are able to make reservations + check out equipment in the Equipment Loan Office. Also, there is no notification/prompt stating that the user is banned when the workers type in their NetID during checkout.
Any help to remedy this issue would be greatly appreciated since users get banned for a reason(s) and we would prefer not to lend our equipment to them.

Currently, we only enforce "banning" on actions that the banned user performs themselves, but other users (e.g. checkout persons) can still create reservations for them and perform reservation actions for them (e.g. check out equipment).

To Do:

• Add banned user validation to the cart
• Add banned user validation for the checkout action
  • This should be soft, we probably want to allow admins and above to override with a warning but otherwise banned users should not be given equipment for any pre-existing reservations. That said, we need to allow other reservation actions (e.g. checkin, edit, etc) regardless of reserver status so that equipment can be returned and other stuff can be done.
• Add flash message [edit: and redirect] when viewing manage / current / other views for banned users

This is pretty urgent, adding it to v5.2.0

[orenyk]

We might even want to back-port this to v3.4...

[orenyk]

Wrote a whole bunch of tests for this, now trying to fix them (woo TDD). Not sure about the "softness" of the validation for creation and checkout... I think that if an admin wants to, for some reason, create a reservation for a banned user or check out an existing reservation to them, they can just un-ban the user, so we'll make it an actual validation.

[orenyk]

Ok, cart validation written and works fine. "Hard" validation for Reservation creation also written, although honestly I don't think we really want to let our users even get there (since it doesn't match our current workflow in terms of being able to override cart validations). So, I currently have it redirecting with a flash error if you try to hit /reservations/new with a banned reserver. I also have a flash error message when you go to /reservations/manage/:id and /reservations/current/:id, but the tests are failing. I'll keep working on this tomorrow, then back-port to v3.4.8.

[orenyk]

Ok! I sorted out a lot of the testing issues (some of which had to do with faulty tests, some of which had to do with missing functionality). Finishing everything up hopefully then on to v3.4!

[orenyk]

I think it's all done, issuing PR.