Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

[1185] Fix Banned Users #1186

Merged
merged 1 commit into from
Mar 23, 2015
Merged

[1185] Fix Banned Users #1186

merged 1 commit into from
Mar 23, 2015

Conversation

orenyk
Copy link
Contributor

@orenyk orenyk commented Mar 10, 2015

Resolves #1185 on master

@squidgetx
Copy link
Contributor

I'm not a big fan of checking errors[0].include? 'banned', seems kind of sloppy to me. Doesn't the cart automatically run certain validations once the reserver is changed? Can we just depend on that and treat it like availability as a hard validation?

@orenyk orenyk mentioned this pull request Mar 17, 2015
Merged
@orenyk
Copy link
Contributor Author

orenyk commented Mar 17, 2015

Hmmm I see what you're saying, something like if @reservation.valid? || @reservation.errors[:base].empty?? It doesn't work in all cases, I'll play around with this and see if I can clean it up.

@squidgetx squidgetx changed the title #1185 Fix Banned Users [1185] Fix Banned Users Mar 23, 2015
@orenyk orenyk force-pushed the 1185_fix_banned_users branch 2 times, most recently from c8dbca1 to 6b12dbf Compare March 23, 2015 00:31
@orenyk
Copy link
Contributor Author

orenyk commented Mar 23, 2015

@squidgetx updated, let me know what you think!

@squidgetx
Copy link
Contributor

Looks good pending travis

@orenyk
Copy link
Contributor Author

orenyk commented Mar 23, 2015

Thanks, just cleaning up some leftover object --> item changes.

@orenyk
Prevent banned users from reserving and checking out equipment
0e9c844 
Resolves #1185
- add Cart validation for banned reservers
- add Reservation validation for banned reservers
- add flash message when viewing banned user profile
- prevent viewing of manage / current view for banned users
- prevent checkout of equipment to banned users
@orenyk orenyk force-pushed the 1185_fix_banned_users branch from 6b12dbf to 0e9c844 Compare March 23, 2015 00:50
orenyk added a commit that referenced this pull request Mar 23, 2015
@orenyk
Merge pull request #1186 from YaleSTC/1185_fix_banned_users
0e9370a 
resolves #1185
@orenyk orenyk merged commit 0e9370a into master Mar 23, 2015
@orenyk orenyk deleted the 1185_fix_banned_users branch April 22, 2015 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pri: 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Banned user validations
2 participants
@orenyk @squidgetx