Documentation links broken (paperclip uploads) [v5.5]

[orenyk]

Two issues: first, the link to the documentation section in the subnavbar of the equipment model show page (here) is broken, it points to the wrong id (should be #documentation)

More importantly, the URL generated by Paperclip (here) ignores the relative root (e.g. instance subdirectory) and so all the actual PDF links are currently broken. It looks like this is a known issue with Paperclip, we'll have to write a helper method to get those links right (not sure why this wasn't an issue with v3.4?).

[orenyk]

Ok, put together a quick helper method. Testing this was difficult as there's no easy way to run rails server while simulating a subdirectory deployment (even if you set RAILS_RELATIVE_ROOT_URL). I ended up having to start the thin server manually with thin start --prefix=/test and also setting the aforementioned environment variable (which broke assets but that's ok). The new helper method seems to work; I'm going to write up a quick test for it and one for the equipment model show page and hopefully we can wrap this up quickly.

[orenyk]

Just realized I really have no idea how to easily test subdirectory deployment in feature specs so I'll just leave it at unit tests for the helper method. Pushing / issuing PR now!