Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

#1017 request email links #1024

Merged
merged 4 commits into from
Oct 27, 2014
Merged

#1017 request email links #1024

merged 4 commits into from
Oct 27, 2014

Conversation

orenyk
Copy link
Contributor

@orenyk orenyk commented Oct 15, 2014

resolves #1017 on master

@aaron-effron
Copy link
Contributor

When I check out this branch, I get a NoMethodError in CatalogController, namely:

"undefined method `enable_renewals' for #AppConfig:0x00000106813e98"

With the following being the code trace:

  when 'admin'
    can :manage, :all
    unless AppConfig.first.enable_renewals
      cannot :renew, Reservation
    end
    cannot :appoint, :superuser

Not exactly sure why this is happening because enable_renewals is defined as true in the schema - perhaps a mixup between a symbol and a method?

@orenyk
Copy link
Contributor Author

orenyk commented Oct 19, 2014

Did you try resetting your database? It's possible that this has to do with jumping between branches? I'm not on Linux right now so I can't check this locally but if you start with a freshly-seeded DB everything should work (although this branch should be hard to test locally... see my comments in #1017).

@orenyk
Copy link
Contributor Author

orenyk commented Oct 27, 2014

merging since we merged #1023

orenyk added a commit that referenced this pull request Oct 27, 2014
@orenyk orenyk merged commit e2c172c into master Oct 27, 2014
@orenyk orenyk deleted the 1017_request_email_links_master branch October 27, 2014 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in admin request e-mail broken
2 participants