Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Merge #235 - Travis CI implementation #641

Merged
merged 8 commits into from
Jul 8, 2014
Merged

Conversation

mnquintana
Copy link
Contributor

See #235

TODO:

@dgoerger
Copy link
Contributor

dgoerger commented Jul 8, 2014

screenshot from 2014-07-08 12 19 19

^ this is new.

@mnquintana
Copy link
Contributor Author

Indeed - now you know it's implemented!

@mnquintana
Copy link
Contributor Author

OH WAIT I think Travis CI is trying to build the merged PR - let's wait and see what happens.

@orenyk
Copy link
Contributor

orenyk commented Jul 8, 2014

So it runs on each pull request?

@mnquintana
Copy link
Contributor Author

Yup, that's the beauty of it - we won't have to manually check if tests or builds are failing anymore!

@@ -0,0 +1,30 @@
development:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be added to the git-ignore file, and copied to a database.travis.yml.example file (just like database.yml), and this info added to appropriate documentation. database setups will vary and we don't want to assume mysql2 with these default settings. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's not how it works. This file is for Travis CI's VMs, and is necessary for automatic builds. There can't be a .example file because this isn't for human setup, it's only for Travis CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see, I didn't realize Travis CI is a hosted service and doesn't use our databases. Can we add that to a comment in the top line, for documentation/clarity?

@orenyk
Copy link
Contributor

orenyk commented Jul 8, 2014

That is so cool :-)

@@ -90,3 +90,7 @@ group :production, :staging do
gem 'therubyracer', require: 'v8'
gem 'airbrake'
end

# group :test do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a placeholder for #598?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that was a test, sorry, I can get rid of that.

@orenyk
Copy link
Contributor

orenyk commented Jul 8, 2014

Can we have the CodeClimate integration set up in this PR as well, since it's relevant?

@mnquintana
Copy link
Contributor Author

@orenyk Sure, I'll add that, although I'm not sure if it'll work until the build passes? We'll see.

As I suspected, the build is hanging indefinitely because it's calling rake app:setup, and waiting for user input. Any suggestions about how to get around that?

@orenyk
Copy link
Contributor

orenyk commented Jul 8, 2014

It's actually running rake db:seed, maybe we can modify it to default to minimal with some dummy netID?

@dgoerger
Copy link
Contributor

dgoerger commented Jul 8, 2014

can we call the seed script minimal=true? we might be able to program a time-out for the user NetID, such that if wait-time is greater than say 30 seconds it uses the NetID "guest" or "catest"? that should get it to pass.

mnquintana added a commit that referenced this pull request Jul 8, 2014
Merge #235 - Travis CI implementation
@mnquintana mnquintana merged commit b0ae554 into development Jul 8, 2014
@orenyk orenyk added this to the 3.4.0 milestone Jul 11, 2014
@squidgetx squidgetx deleted the 235_travis_ci branch July 15, 2014 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants