-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
Indeed - now you know it's implemented! |
OH WAIT I think Travis CI is trying to build the merged PR - let's wait and see what happens. |
So it runs on each pull request? |
Yup, that's the beauty of it - we won't have to manually check if tests or builds are failing anymore! |
@@ -0,0 +1,30 @@ | |||
development: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should be added to the git-ignore file, and copied to a database.travis.yml.example file (just like database.yml), and this info added to appropriate documentation. database setups will vary and we don't want to assume mysql2 with these default settings. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately that's not how it works. This file is for Travis CI's VMs, and is necessary for automatic builds. There can't be a .example
file because this isn't for human setup, it's only for Travis CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, I didn't realize Travis CI is a hosted service and doesn't use our databases. Can we add that to a comment in the top line, for documentation/clarity?
That is so cool :-) |
@@ -90,3 +90,7 @@ group :production, :staging do | |||
gem 'therubyracer', require: 'v8' | |||
gem 'airbrake' | |||
end | |||
|
|||
# group :test do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a placeholder for #598?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that was a test, sorry, I can get rid of that.
Can we have the CodeClimate integration set up in this PR as well, since it's relevant? |
@orenyk Sure, I'll add that, although I'm not sure if it'll work until the build passes? We'll see. As I suspected, the build is hanging indefinitely because it's calling rake app:setup, and waiting for user input. Any suggestions about how to get around that? |
It's actually running |
can we call the seed script minimal=true? we might be able to program a time-out for the user NetID, such that if wait-time is greater than say 30 seconds it uses the NetID "guest" or "catest"? that should get it to pass. |
Merge #235 - Travis CI implementation
See #235
TODO:
db/schema.rb
broken? #636)