This repository was archived by the owner on Jul 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Merge #235 - Travis CI implementation #641
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1a4c8e
setup Travis CI #235
ca2df70
setup database.yml for travis ci, fix double rake gem issue
083d328
sets up database before building
245a627
adds bundle exec
8fb8171
remove commented out test from gemfile
3f58996
adds comment clarifying purpose of database.travis.yml
29ce74d
adds code climate token
e5274ae
new approach to environment setup
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
language: ruby | ||
rvm: | ||
- 2.1.1 | ||
- 1.9.3 | ||
before_script: | ||
- cp config/database.travis.yml config/database.yml | ||
- CODECLIMATE_REPO_TOKEN=075afb721fe089e1b77ab194fcff1ac132765bbfd3f3777db52f7abaf9bf800d | ||
- bundle exec rake db:create | ||
- bundle exec rake db:migrate | ||
- bundle exec rake db:test:prepare |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# This database.yml is for use by Travis CI. All this information must be | ||
# provided so Travis CI can actually build and test our app. It cannot | ||
# be removed and replaced by a database.yml.example file, because this is | ||
# configuration information necessary for Travis CI to build the app. For more | ||
# information, see http://docs.travis-ci.com/user/database-setup/#MySQL | ||
# | ||
# It is possible that with any further changes in the future we'll need to | ||
# update this configuration for Travis CI to build. Always check the Travis CI | ||
# build status for the latest information. | ||
# ============================================================================== | ||
|
||
development: | ||
adapter: mysql2 | ||
encoding: utf8 | ||
reconnect: false | ||
database: reservations_development | ||
pool: 5 | ||
username: root | ||
password: | ||
host: localhost | ||
|
||
# Warning: The database defined as "test" will be erased and | ||
# re-generated from your development database when you run "rake". | ||
# Do not set this db to the same as development or production. | ||
test: | ||
adapter: mysql2 | ||
encoding: utf8 | ||
reconnect: false | ||
database: reservations_test | ||
pool: 5 | ||
username: root | ||
password: | ||
|
||
production: | ||
adapter: mysql2 | ||
encoding: utf8 | ||
reconnect: false | ||
database: reservations_production | ||
pool: 5 | ||
username: root | ||
password: |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should be added to the git-ignore file, and copied to a database.travis.yml.example file (just like database.yml), and this info added to appropriate documentation. database setups will vary and we don't want to assume mysql2 with these default settings. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately that's not how it works. This file is for Travis CI's VMs, and is necessary for automatic builds. There can't be a
.example
file because this isn't for human setup, it's only for Travis CI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, I didn't realize Travis CI is a hosted service and doesn't use our databases. Can we add that to a comment in the top line, for documentation/clarity?