Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

#753 first user = superuser #931

Merged
merged 5 commits into from
Sep 12, 2014
Merged

#753 first user = superuser #931

merged 5 commits into from
Sep 12, 2014

Conversation

orenyk
Copy link
Contributor

@orenyk orenyk commented Aug 29, 2014

resolves #753

@orenyk orenyk modified the milestone: 4.0.0 Sep 5, 2014
@orenyk
Copy link
Contributor Author

orenyk commented Sep 5, 2014

The only thing I'm not sure about for this is whether or not this is actually a good idea. If we operate on the assumption that the person running rake app:setup will create a developer / devops account for themselves, rather than one of the usual admins, then this is safe. However, if they're just creating an account for an admin then we'll be giving that admin way too much power. Thoughts?

@orenyk
Copy link
Contributor Author

orenyk commented Sep 10, 2014

check seed.rb

@coollog
Copy link
Contributor

coollog commented Sep 12, 2014

Should change the text when not set up from "Hey there! It looks like you haven't fully set up your application yet. To create your first admin user and configure the application, please run $bundle exec rake app:setup in the terminal. For more information, please see our github page: https://github.com/YaleSTC/reservations" to "... create your first super user and configure the application ..."

And the rake app:setup text "Welcome to reservations! Before using your application, we need to create an
initial administrator account and set some application-wide configurations.
This administrator account can be used later to create other admins, import
users, and change any configurations that you set from this script. With
that in mind, let's get started!

We need to start by creating an admin account. Please enter the
following info:"
to be about setting up the initial super user instead.

Otherwise, the first user created is a Super User as intended. Reviewed.

@orenyk
Copy link
Contributor Author

orenyk commented Sep 12, 2014

Great catches, I'll get those prompts changed and then we can merge. Thanks!

@orenyk
Copy link
Contributor Author

orenyk commented Sep 12, 2014

We had some weird bundle issues; we should start specifying versions in our Gemfile for stability anyway, so I fixed it by specifying the version of paper_trail (we've seen this error before). Now that we're green I'm merging this in :-)

orenyk added a commit that referenced this pull request Sep 12, 2014
@orenyk orenyk merged commit a31fbf4 into master Sep 12, 2014
@orenyk orenyk deleted the 753_first_user_superuser branch October 27, 2014 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up first user as superuser in app:setup
2 participants