#990 Fixed linkto confirm

[orenyk]

Resolved #990

[coollog]

I found that a few files have a link_to syntax with "confirm:" not encapsulated in a data dictionary.

Searching 444 files for "confirm: "

C:\Dropbox\School\Yale\stc\reservations\app\views\announcements\index.html.erb:
   18      <td><%= announcement.ends_at.strftime('%m/%d/%Y') %></td>
   19      <td><%= link_to "Edit", edit_announcement_path(announcement), :class => "btn"  %></td>
   20:     <td><%= link_to 'Delete', announcement, method: :delete, data: { confirm: 'Are you sure?' },  :class => "btn btn-danger"  %></td>
   21    </tr>
   22    <% end %>

C:\Dropbox\School\Yale\stc\reservations\app\views\blackouts\_table.html.erb:
   52          <% end %>
   53          <td><%= link_to 'Edit', edit_blackout_path(blackout), class: 'btn' %></td>
   54:         <td><%= link_to 'Delete', blackout, confirm: 'Are you sure?', method: :delete, class: 'btn btn-danger' %></td>
   55        </tr>
   56      <% end %>

C:\Dropbox\School\Yale\stc\reservations\app\views\blackouts\show.html.erb:
   36    <%= link_to 'Edit', edit_blackout_path(@blackout), :class => 'btn' %>
   37    <%= link_to 'View all blackout dates', blackouts_path, :class => 'btn' %>
   38:   <%= link_to 'Delete', @blackout, confirm: 'Are you sure?', method: :delete, class: 'btn btn-danger' %>
   39  <% end %>
   40  

C:\Dropbox\School\Yale\stc\reservations\app\views\reservations\_new_request.html.erb:
   41  
   42    <div class="form-actions">
   43:     <%= f.button :submit, "Submit Request", confirm: "Are you sure? This request is not finalized and will be subject to approval by an administrator. It will not be available for checkout until and unless approved, and the request may be denied for any reason at the sole discretion of the administrator." %>
   44      <%= link_to "Return to Catalog", catalog_path, class: 'btn' %>
   45    </div>

4 matches across 4 files

[orenyk]

I fixed the few missing ones (some of the results come from using the later Ruby hash syntax) and made the spacing consistent. Ready for final review!

[coollog]

Checked all links (except below) and all seem to work. Checked for any files with confirm: not in data: dictionary and none showed up. Good to go!

equipment_model/#/edit, users/#/edit, and categories/#/edit delete leads to error. Filed new issue: #1036

[orenyk]

These links were known to be broken (see #957) and should be removed soon. Merging!